Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make net.transport an optional attribute #8245

Closed
mateuszrzeszutek opened this issue Apr 7, 2023 · 2 comments · Fixed by #8279
Closed

Make net.transport an optional attribute #8245

mateuszrzeszutek opened this issue Apr 7, 2023 · 2 comments · Fixed by #8279
Assignees
@mateuszrzeszutek
Labels
enhancement New feature or request

Comments

@mateuszrzeszutek
Copy link
Member

  • Make the getter methods default with return null implementation;
  • Remove the attribute from HTTP semantic conventions;
  • Remove hard-coded values (as much as it makes sense to do so).

Linked conversation: #8131 (comment)
@mateuszrzeszutek mateuszrzeszutek added the enhancement New feature or request label Apr 7, 2023
@mateuszrzeszutek mateuszrzeszutek self-assigned this Apr 7, 2023
@trask
Copy link
Member

trask commented Apr 7, 2023

just checking, only for net.transport.name, or for both net.transport.name and net.transport.version?

@mateuszrzeszutek
Copy link
Member Author

There's only net.transport, there are no name/version attributes for it (it's the IP_TCP one)

@mateuszrzeszutek mateuszrzeszutek mentioned this issue Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mateuszrzeszutek mateuszrzeszutek

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make net.transport an optional attribute mateuszrzeszutek/opentelemetry-java-instrumentation
2 participants
@trask @mateuszrzeszutek