Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document OTEL_RESOURCE_ATTRIBUTES support in README #704

Closed
trask opened this issue Jul 15, 2020 · 3 comments · Fixed by #783
Closed

Document OTEL_RESOURCE_ATTRIBUTES support in README #704

trask opened this issue Jul 15, 2020 · 3 comments · Fixed by #783
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@trask
Copy link
Member

trask commented Jul 15, 2020

Probably a new section, e.g. just above https://github.com/open-telemetry/opentelemetry-java-instrumentation#batch-span-processor.

Also, document how to use OTEL_RESOURCE_ATTRIBUTES to set the OTLP exporter service.name (probably directly within the OTLP config section, at least until #703 is resolved).

@trask trask added the documentation Improvements or additions to documentation label Jul 15, 2020
@tedsuo
Copy link

tedsuo commented Jul 15, 2020

Just to clarify, does the OTEL_RESOURCE_ATTRIBUTES still exist? It seems like it is an option for OTLP, but also seems like it was removed in PR #424 (I assume it still does exist, based on the existence of this issue 😄 )

Related, there is an effort to standardize these common env vars here: open-telemetry/opentelemetry-specification#666

cc @anuraaga as I saw you use this config option.

@trask
Copy link
Member Author

trask commented Jul 16, 2020

Hey @tedsuo, OTEL_RESOURCE_ATTRIBUTES wasn't removed in #424. That environment variable directly configures the OpenTelemetry Java SDK.

@tedsuo
Copy link

tedsuo commented Jul 16, 2020

Derp, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants