Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement database span semantic convention updates #697

Closed
justinfoote opened this issue Jul 15, 2020 · 1 comment · Fixed by #785
Closed

Implement database span semantic convention updates #697

justinfoote opened this issue Jul 15, 2020 · 1 comment · Fixed by #785
Assignees

Comments

@justinfoote
Copy link
Member

The semantic conventions for database spans was recently updated. See:
open-telemetry/opentelemetry-specification#575

The instrumentation needs to be updated with these new attributes.

Primary among them is db.system, which applies to all database spans.
Also some connection-level attributes and the call-level attributes:

  • db.name
  • db.statement
  • db.operation
@justinfoote justinfoote changed the title Implement database semantic conventions Implement database span semantic convention updates Jul 15, 2020
@trask trask added specification contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome labels Jul 15, 2020
@heyams
Copy link
Contributor

heyams commented Jul 21, 2020

Please assign this to me. Thank you!

@trask trask removed the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants