Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture net.host.name and net.host.port for SERVER spans? #5375

Closed
trask opened this issue Feb 14, 2022 · 2 comments
Closed

Capture net.host.name and net.host.port for SERVER spans? #5375

trask opened this issue Feb 14, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@trask
Copy link
Member

trask commented Feb 14, 2022

I think we should probably at least capture net.host.name and net.host.port when there's no http.host (i.e. HTTP 1.0) in order to satisfy:

Additional attribute requirements: At least one of the following sets of attributes is required:

I'm guessing we would add these to NetServerAttributesGetter(?)

And then the question is, should we:

  • somehow make capturing net.host.name and net.host.port conditional on absence of http.host, or
  • always capture net.host.name and net.host.port
@trask trask added the enhancement New feature or request label Feb 14, 2022
@mateuszrzeszutek
Copy link
Member

  • somehow make capturing net.host.name and net.host.port conditional on absence of http.host

Hmm, that'd probably make net attributes extractors depend on the http getter (if we want to preserve the order of importance in the attribute sets list). It would probably be cleaner (from the code perspective) to capture both net.host.* and http.host -- also, we do a similar thing in the HTTP client instrumentations, we capture both http.url and net.peer.*.

@mateuszrzeszutek
Copy link
Member

I think it's been implemented already in one of my HTTP semconv PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants