Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically append baggage entries to span attributes #4520

Closed
stanosamek opened this issue Oct 27, 2021 · 6 comments · Fixed by #11697
Closed

Automatically append baggage entries to span attributes #4520

stanosamek opened this issue Oct 27, 2021 · 6 comments · Fixed by #11697
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request

Comments

@stanosamek
Copy link

Hi,

like we were discussing about adding configuration for adding baggage entries as span attributes to every span in #4518 or #4351. It would be great to have some configuration for turning on or off adding baggage entries to spans.

Currently we are not able to propagate baggage entries. Except for creating custom extension.

Actually we are not able to create some analytical solution without these baggage entries.

Thank you

@stanosamek stanosamek added the enhancement New feature or request label Oct 27, 2021
@trask trask added the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Oct 27, 2021
@MALPI
Copy link
Contributor

MALPI commented Aug 9, 2022

hey @trask,

I'm slightly confused. Is the feature of baggage item propagation in general available or not. The two discussions referenced are contradicting each other?

Best

@trask
Copy link
Member

trask commented Aug 9, 2022

Baggage is automatically propagated, but is not automatically attached as span attributes when exporting

@MALPI
Copy link
Contributor

MALPI commented Aug 9, 2022

Thanks for confirming. If you can give me a hint in which direction I should search, I would give it a try to implement.

@cuichenli
Copy link
Contributor

just out of curious, should this be done on the sdk side or the instrumentation side?

@mateuszrzeszutek
Copy link
Member

OpenTelemetry SDK only includes specced components. This feature (appending baggage as span attributes) probably fits either this repo or contrib more (contrib seems to be a somewhat more suitable place now that I think of it; cause it's not an instrumentation).

@mateuszrzeszutek mateuszrzeszutek changed the title Configuration of baggage propagation Automatically append baggage entries to span attributes Feb 1, 2023
@SylvainJuge
Copy link
Contributor

A span processor has been added in contrib with this PR: open-telemetry/opentelemetry-java-contrib#1290, so it might be a matter of reusing it in the agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request
Projects
None yet
6 participants