You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was browsing Instrumenter code and noticed that the the instrumentation version passed when obtaining the tracer is Instrumentation.VERSION. See code here.
My understanding is that the goal is to have folks instrument their libraries with Instrumenter, in which case it will be incorrect to include the version of the artifact that contains Instrumenter. We'll want callers to specify the version of the library they're instrumenting, right?
No optional is available for specifying the schema url in the tracer or meter. And what should the schema url be anyway? The Instrumenter provides tools to make it easier to follow the semantic conventions, but someone could use it and still violate them.
Just wanted to call these out so we can sort out the desired behavior.
The text was updated successfully, but these errors were encountered:
My understanding is that the goal is to have folks instrument their libraries with Instrumenter, in which case it will be incorrect to include the version of the artifact that contains Instrumenter. We'll want callers to specify the version of the library they're instrumenting, right?
It should be the version of instrumentation library not the version of instrumented library
I was browsing
Instrumenter
code and noticed that the the instrumentation version passed when obtaining the tracer isInstrumentation.VERSION
. See code here.My understanding is that the goal is to have folks instrument their libraries with
Instrumenter
, in which case it will be incorrect to include the version of the artifact that containsInstrumenter
. We'll want callers to specify the version of the library they're instrumenting, right?Also noticed:
Instrumenter
provides tools to make it easier to follow the semantic conventions, but someone could use it and still violate them.Just wanted to call these out so we can sort out the desired behavior.
The text was updated successfully, but these errors were encountered: