Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumenter instrumentation version and schema url #4333

Closed
jack-berg opened this issue Oct 8, 2021 · 2 comments · Fixed by #5752
Closed

Instrumenter instrumentation version and schema url #4333

jack-berg opened this issue Oct 8, 2021 · 2 comments · Fixed by #5752
Assignees
Labels
enhancement New feature or request

Comments

@jack-berg
Copy link
Member

I was browsing Instrumenter code and noticed that the the instrumentation version passed when obtaining the tracer is Instrumentation.VERSION. See code here.

My understanding is that the goal is to have folks instrument their libraries with Instrumenter, in which case it will be incorrect to include the version of the artifact that contains Instrumenter. We'll want callers to specify the version of the library they're instrumenting, right?

Also noticed:

  • No version is passed when obtaining a meter provider. We'll probably want to be consistent.
  • No optional is available for specifying the schema url in the tracer or meter. And what should the schema url be anyway? The Instrumenter provides tools to make it easier to follow the semantic conventions, but someone could use it and still violate them.

Just wanted to call these out so we can sort out the desired behavior.

@jack-berg jack-berg added the enhancement New feature or request label Oct 8, 2021
@trask
Copy link
Member

trask commented Oct 11, 2021

linking related issue: #2761

@laurit
Copy link
Contributor

laurit commented Nov 11, 2021

version added in #4611

My understanding is that the goal is to have folks instrument their libraries with Instrumenter, in which case it will be incorrect to include the version of the artifact that contains Instrumenter. We'll want callers to specify the version of the library they're instrumenting, right?

It should be the version of instrumentation library not the version of instrumented library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants