Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary URL construction #3699

Closed
trask opened this issue Jul 28, 2021 · 1 comment · Fixed by #4209
Closed

Remove unnecessary URL construction #3699

trask opened this issue Jul 28, 2021 · 1 comment · Fixed by #4209
Labels
enhancement New feature or request

Comments

@trask
Copy link
Member

trask commented Jul 28, 2021

Constructing URL objects is a bit costly (in addition to memory, it does a lot of validation), and we construct them in various http server and http client instrumentations, generally in order to populate http.url attribute. This could probably be optimized by adding some kind of "uri builder" to our api that can be used instead.

@trask trask added the enhancement New feature or request label Jul 28, 2021
@anuraaga
Copy link
Contributor

I think the intent of the semantic conventions is to only return a URL if we have a URL, or otherwise return the parts, target, host, etc. Though not sure if this just makes it too confusing when writing instrumentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants