Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to capture when Apache HttpClient 5 is passed HttpHost + absolute URI? #3697

Closed
trask opened this issue Jul 28, 2021 · 1 comment
Closed

Comments

@trask
Copy link
Member

trask commented Jul 28, 2021

The scheme/host/port can either be captured from the HttpHost, or from the absolute URI.

I thought that we should capture the values from HttpHost since those are what's used.

But then I found that all versions except for early 4.x versions use the scheme/host/port from the absolute URI when they get back a host-relative redirect from the server.

So then I got confused, and just made the tests use the same scheme/host/port in both HttpHost and the absolute URI in order to make the redirect tests pass. But we should revisit and tighten up the tests once we decide what should be captured where.

@trask
Copy link
Member Author

trask commented Dec 22, 2024

Closing, can revisit later if anyone has renewed interest.

@trask trask closed this as completed Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant