Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kafka-streams-0.11 latestDepTest limits #3451

Closed
mateuszrzeszutek opened this issue Jun 30, 2021 · 2 comments
Closed

Remove kafka-streams-0.11 latestDepTest limits #3451

mateuszrzeszutek opened this issue Jun 30, 2021 · 2 comments
Labels
area:tests bug Something isn't working

Comments

@mateuszrzeszutek
Copy link
Member

Describe the bug
Looks like we're limiting kafka-streams version to 2.3+: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/kafka-streams-0.11/javaagent/build.gradle.kts#L33
It turns out the instrumentation had an issue for 2.6 (#3436), and our latest dep tests completely did not detect that.

When I tried bumping the version the groovy compile task was failing on a missing KafkaEmbedded class. We should remove the KafkaEmbedded junit rule and use Kafka testcontainers instead.

@mateuszrzeszutek mateuszrzeszutek added bug Something isn't working area:tests labels Jun 30, 2021
@tylerbenson
Copy link
Member

You can see an alternate fix in my PR here: DataDog/dd-trace-java#2951
(This replaces KafkaEmbedded with EmbeddedKafkaBroker instead of switching to testcontainers. Not opposed to switching to testcontainers, this was just an easier fix for me.)

@laurit
Copy link
Contributor

laurit commented Aug 17, 2021

Resolved in #3803

@laurit laurit closed this as completed Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants