Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename build files to build.gradle #3408

Closed
anuraaga opened this issue Jun 25, 2021 · 3 comments · Fixed by #3409
Closed

Rename build files to build.gradle #3408

anuraaga opened this issue Jun 25, 2021 · 3 comments · Fixed by #3409
Labels
enhancement New feature or request

Comments

@anuraaga
Copy link
Contributor

I'd like to propose renaming our build files to the standard Gradle default. After working on the repo and probably the most on Gradle files, I've found no real benefit in navigating among build scripts (IDE brings up the folder names too when jumping around) by having the names but have some trouble with copy-pasting files. I believe last year I checked github.com/gradle/gradle and they did actually use the non-default file names in that repo, but now they seem to have changed

https://github.com/gradle/gradle/tree/master/subprojects

This is probably for consistency with the general Gradle ecosystem and I feel following the pattern of gradle/gradle is a good one for us. This logic is a bit massive for what we get of it IMO

https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/settings.gradle#L319

@anuraaga anuraaga added the enhancement New feature or request label Jun 25, 2021
@anuraaga
Copy link
Contributor Author

I'll make the change if there's agreement.

@iNikem
Copy link
Contributor

iNikem commented Jun 26, 2021

So how exactly can I now find/open a specific build file? E.g. we have latest dep test failing for a rabbit module and I want to open the build file for that module.

@anuraaga
Copy link
Contributor Author

I usually use Intellij shift-shift and enter the name of the project which surfaces the folder. Github works similar too when I use the file navigator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants