Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty client spans don't capture any span attributes on connection failure #3103

Closed
trask opened this issue May 27, 2021 · 0 comments · Fixed by #3115
Closed

Netty client spans don't capture any span attributes on connection failure #3103

trask opened this issue May 27, 2021 · 0 comments · Fixed by #3115

Comments

@trask
Copy link
Member

trask commented May 27, 2021

Not sure if it's even possible, but would be nice if Netty instrumentation could capture the same span attributes on connection failure as other http client instrumentation.

Currently it captures a span named CONNECT with no attributes:

Context errorContext = tracer().startSpan("CONNECT", SpanKind.CLIENT);
tracer().endExceptionally(errorContext, cause);

And the netty tests suppress the normal test verification of span attributes for these requests:

  @Override
  boolean hasClientSpanAttributes(URI uri) {
    switch (uri.toString()) {
      case "http://localhost:61/": // unopened port
      case "http://www.google.com:81/": // dropped request
      case "https://192.0.2.1/": // non routable address
        return false
      default:
        return true
    }
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant