-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate otel.exporter.jar and otel.initializer.jar into single feature otel.javaagent.extensions? #2442
Comments
Adding note here about benefits of runtime shading: #2570 (reply in thread) |
Also note that as part of this we will drop |
Doh. Issue predates the PR |
@trask : I was trying out "otel.javaagent.experimental.initializer.jar" system property. It seems to work when i provide the path of the exact jar file. But when i provide the path of a folder that contains multiple jars, it does not seem to load those jars. Is that something expected as based on your description above it seems its expected to work with folders containing multiple jars as well. |
ya, this has not been implemented yet, but is planned |
@trask : Any idea by when it would be implemented. |
During the June |
@trask : Thanks for notifying. |
otel.javaagent.extensions
could be a single jar file, a list of jar files, or a folder with jar filesIt would behave same as
otel.initializer.jar
where those jar files just get added toAgentClassLoader
(or even better follow @jsuereth's proposal of loading them in a mostly-isolated child ofAgentClassLoader
).And all of the normal autoconfigure SPIs can be used to add exporters, span processors, propagators.
I like the runtime shading of the existing
ExporterClassLoader
, but would probably vote to do away with it due to startup overhead, and make sure we document how to shade properly using both gradle and maven.The text was updated successfully, but these errors were encountered: