Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate otel.exporter.jar and otel.initializer.jar into single feature otel.javaagent.extensions? #2442

Closed
trask opened this issue Mar 1, 2021 · 9 comments

Comments

@trask
Copy link
Member

trask commented Mar 1, 2021

otel.javaagent.extensions could be a single jar file, a list of jar files, or a folder with jar files

It would behave same as otel.initializer.jar where those jar files just get added to AgentClassLoader (or even better follow @jsuereth's proposal of loading them in a mostly-isolated child of AgentClassLoader).

And all of the normal autoconfigure SPIs can be used to add exporters, span processors, propagators.

I like the runtime shading of the existing ExporterClassLoader, but would probably vote to do away with it due to startup overhead, and make sure we document how to shade properly using both gradle and maven.

@trask
Copy link
Member Author

trask commented Mar 17, 2021

Adding note here about benefits of runtime shading: #2570 (reply in thread)

@trask
Copy link
Member Author

trask commented May 11, 2021

Also note that as part of this we will drop io.opentelemetry.javaagent.tooling.exporter.SpanExporterFactory, and only support io.opentelemetry.sdk.autoconfigure.spi.ConfigurableSpanExporterProvider from io.opentelemetry:opentelemetry-sdk-extension-autoconfigure

@tobias-
Copy link

tobias- commented May 19, 2021

Nit: They're otel.javaagent.experimental.exporter.jar and otel.javaagent.experimental.initializer.jar

Doh. Issue predates the PR

@sumitm-iiit
Copy link

@trask : I was trying out "otel.javaagent.experimental.initializer.jar" system property. It seems to work when i provide the path of the exact jar file. But when i provide the path of a folder that contains multiple jars, it does not seem to load those jars. Is that something expected as based on your description above it seems its expected to work with folders containing multiple jars as well.

@trask
Copy link
Member Author

trask commented Jun 4, 2021

when i provide the path of a folder that contains multiple jars, it does not seem to load those jars

ya, this has not been implemented yet, but is planned

@sumitm-iiit
Copy link

@trask : Any idea by when it would be implemented.

@iNikem
Copy link
Contributor

iNikem commented Jun 5, 2021

@trask : Any idea by when it would be implemented.

During the June

@trask
Copy link
Member Author

trask commented Aug 25, 2021

@trask trask closed this as completed Aug 25, 2021
@sumitm-iiit
Copy link

@trask : Thanks for notifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants