Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record internal metric for SQL cache misses. #2123

Closed
breedx-splk opened this issue Jan 26, 2021 · 1 comment · Fixed by #2747
Closed

Record internal metric for SQL cache misses. #2123

breedx-splk opened this issue Jan 26, 2021 · 1 comment · Fixed by #2747
Labels
enhancement New feature or request

Comments

@breedx-splk
Copy link
Contributor

In #2094 we introduced a cache for SQL sanitization/extraction to reduce the number of times that a familiar statement would need to undergo expensive parsing. This was done in order to help reduce the overhead of the very common jdbc instrumentation.

It is expected that most common applications and frameworks will have a fixed/finite set of SQL statements used at runtime. There will be dynamically generated SQL statements that happen for some users, but we expect these exceptions to be rare. Currently, when a SQL statement is not found in the cache and additional parsing has to happen, we log a message at trace, but this is likely to be unseen.

Let's create and increment an internal metric for parsed SQL cache misses. This will allow users and operators troubleshooting jdbc instrumentation to determine how effective the cache is. It could also allow tuning of this cache (size, lifetime, etc) for future users.

Before starting on this, we should agree what to call it and what its namespace should be.

@breedx-splk breedx-splk added the enhancement New feature or request label Jan 26, 2021
@breedx-splk breedx-splk changed the title Report internal metric for SQL cache misses. Record internal metric for SQL cache misses. Jan 26, 2021
@mateuszrzeszutek
Copy link
Member

We could use SupportabilityMetrics for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants