Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong labeling rules #10661

Closed
steverao opened this issue Feb 25, 2024 · 0 comments · Fixed by #10662
Closed

Wrong labeling rules #10661

steverao opened this issue Feb 25, 2024 · 0 comments · Fixed by #10662
Labels
bug Something isn't working needs triage New issue that requires triage

Comments

@steverao
Copy link
Contributor

steverao commented Feb 25, 2024

Describe the bug

No matter what content is modified, it will be labeled test native. Such as #10658, #10421. I think there are something wrong in PR #10653. I saw the rule format is belong to v5, Relevant docs is here. If we want to add test native label to any change to instrumentation/logback/logback-appender-10/library/**instrumentation/jdbc/library/**instrumentation/spring/**smoke-tests-otel-starter/** within the source dir EXCEPT for the instrumentation/spring/**/javaagent/**
We should add a top-level key all. Relevant labeler rule using description is as following:
image

Steps to reproduce

Create a PR to modify document.

Expected behavior

Just add test native label to necessary modules modified.

Actual behavior

No matter what content is modified, it will be labeled test native.

Javaagent or library instrumentation version

latest

Environment

JDK:
OS:

Additional context

No response

@steverao steverao added bug Something isn't working needs triage New issue that requires triage labels Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage New issue that requires triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant