From 65cb9bbaa80c13bf3ffb9a3d46bc458a7efe3070 Mon Sep 17 00:00:00 2001 From: Mateusz Rzeszutek Date: Wed, 9 Aug 2023 12:33:01 +0200 Subject: [PATCH] renamed net->network extractors --- ...utesGetter.java => DubboNetworkServerAttributesGetter.java} | 2 +- .../apachedubbo/v2_7/DubboTelemetryBuilder.java | 3 ++- ...butesGetter.java => GrpcNetworkServerAttributesGetter.java} | 2 +- .../instrumentation/grpc/v1_6/GrpcTelemetryBuilder.java | 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-) rename instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/{DubboNetServerAttributesGetter.java => DubboNetworkServerAttributesGetter.java} (95%) rename instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/{GrpcNetServerAttributesGetter.java => GrpcNetworkServerAttributesGetter.java} (96%) diff --git a/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboNetServerAttributesGetter.java b/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboNetworkServerAttributesGetter.java similarity index 95% rename from instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboNetServerAttributesGetter.java rename to instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboNetworkServerAttributesGetter.java index cad05795dd9c..0d1bc51acee8 100644 --- a/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboNetServerAttributesGetter.java +++ b/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboNetworkServerAttributesGetter.java @@ -11,7 +11,7 @@ import javax.annotation.Nullable; import org.apache.dubbo.rpc.Result; -final class DubboNetServerAttributesGetter +final class DubboNetworkServerAttributesGetter implements ServerAttributesGetter, ClientAttributesGetter { diff --git a/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboTelemetryBuilder.java b/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboTelemetryBuilder.java index 43adbf939e40..f9d99301aba1 100644 --- a/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboTelemetryBuilder.java +++ b/instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboTelemetryBuilder.java @@ -63,7 +63,8 @@ public DubboTelemetry build() { SpanNameExtractor spanNameExtractor = RpcSpanNameExtractor.create(rpcAttributesGetter); DubboNetClientAttributesGetter netClientAttributesGetter = new DubboNetClientAttributesGetter(); - DubboNetServerAttributesGetter netServerAttributesGetter = new DubboNetServerAttributesGetter(); + DubboNetworkServerAttributesGetter netServerAttributesGetter = + new DubboNetworkServerAttributesGetter(); InstrumenterBuilder serverInstrumenterBuilder = Instrumenter.builder( diff --git a/instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcNetServerAttributesGetter.java b/instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcNetworkServerAttributesGetter.java similarity index 96% rename from instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcNetServerAttributesGetter.java rename to instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcNetworkServerAttributesGetter.java index ad47f958745f..3fd4406d9082 100644 --- a/instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcNetServerAttributesGetter.java +++ b/instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcNetworkServerAttributesGetter.java @@ -12,7 +12,7 @@ import java.net.SocketAddress; import javax.annotation.Nullable; -final class GrpcNetServerAttributesGetter +final class GrpcNetworkServerAttributesGetter implements ServerAttributesGetter, ClientAttributesGetter { diff --git a/instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcTelemetryBuilder.java b/instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcTelemetryBuilder.java index 1e05ccf1342f..309bb4fd48bc 100644 --- a/instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcTelemetryBuilder.java +++ b/instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcTelemetryBuilder.java @@ -176,7 +176,8 @@ public GrpcTelemetry build() { .addAttributesExtractors(additionalExtractors)); GrpcNetClientAttributesGetter netClientAttributesGetter = new GrpcNetClientAttributesGetter(); - GrpcNetServerAttributesGetter netServerAttributesGetter = new GrpcNetServerAttributesGetter(); + GrpcNetworkServerAttributesGetter netServerAttributesGetter = + new GrpcNetworkServerAttributesGetter(); GrpcRpcAttributesGetter rpcAttributesGetter = GrpcRpcAttributesGetter.INSTANCE; clientInstrumenterBuilder