[collector] move app.kubernetes.io/component to be only labels not selectors #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
dmitryax,
povilasv and
a team
as code owners
jaronoff97
approved these changes
Nov 26, 2024
Comment on lines
+35
to
+37
| serviceAccount: | ||
| create: false | ||
| name: "example-opentelemetry-collector" |
There was a problem hiding this comment.
Why is this change needed?
There was a problem hiding this comment.
The example suffers from the fact that we can only have 1 serviceAccount.yaml file saved in the dir. This was causing a race condition between whether the daemonset or deployment got to render it. This wasn't a problem before bc the component label wasnt there to differentiate but now it is.
In reality a user when doing 2 installs would get 2 different service accounts based on the install names. But this example saves the objects as files and we cant control the file name output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1396 (comment)