Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align open-telemetry-operator Helm Chart with Deprecated create-rbac-permission flag #1224

Closed
SergK opened this issue Jun 15, 2024 · 0 comments · Fixed by #1225
Closed

Align open-telemetry-operator Helm Chart with Deprecated create-rbac-permission flag #1224

SergK opened this issue Jun 15, 2024 · 0 comments · Fixed by #1225
Labels
chart:operator Issue related to opentelemetry-operator helm chart

Comments

@SergK
Copy link
Contributor

SergK commented Jun 15, 2024

Is your feature request related to a problem? Please describe.
The create-rbac-permission flag is deprecated as per discussions in open-telemetry/opentelemetry-operator#2588 and changes in open-telemetry/opentelemetry-operator#2787. This deprecation impacts the open-telemetry-operator helm chart, specifically the createRbacPermissions flag, which could affect the functionality of k8sattributes.

Describe the solution you'd like
To align the helm chart with the deprecation of the create-rbac-permission flag, it is essential to ensure the SERVICE_ACCOUNT_NAME environment variable is available inside the pod, as indicated by the source code in open-telemetry/opentelemetry-operator/internal/autodetect/rbac/check.go#L29 and the manager configuration open-telemetry/opentelemetry-operator/config/manager/manager.yaml#L55.

Describe alternatives you've considered
N/A

Additional context
Ensuring the SERVICE_ACCOUNT_NAME environment variable is set correctly is crucial for the functionality of k8sattributes following the deprecation of the create-rbac-permission flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:operator Issue related to opentelemetry-operator helm chart
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants