Use auto-instrumentation SDK in global tracing #5920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
force-pushed
the
global-auto-sdk
branch
from
a684c84 to
38fc53a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5920 +/- ##
=======================================
- Coverage 84.6% 82.1% -2.6%
=======================================
Files 272 273 +1
Lines 22883 23615 +732
=======================================
+ Hits 19381 19397 +16
- Misses 3157 3873 +716
Partials 345 345
|
MrAlias
force-pushed
the
global-auto-sdk
branch
from
714c8a2 to
38ddafd
Compare
When the auto-instrumentation attaches to a process using the global TracerProvider, and there has not been a delegate set, create a span from the go.opentelemetry.io/auto/sdk package so the OTel Go auto-instrumentation can instrument the application by default.
MrAlias
force-pushed
the
global-auto-sdk
branch
from
3e39369 to
85a116d
Compare
MrAlias
requested review from
XSAM,
dashpole,
pellared and
dmathieu
as code owners
dashpole
reviewed
Oct 25, 2024
MrAlias
force-pushed
the
global-auto-sdk
branch
from
155c165 to
85a116d
Compare
dashpole
approved these changes
Oct 25, 2024
pellared
reviewed
Oct 28, 2024
pellared
reviewed
Oct 28, 2024
Do not allow use of auto/sdk outside of global pkg.
dmathieu
approved these changes
Oct 29, 2024
pellared
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Discussed offline with @MrAlias.
We think that before merging this it would be good to:
- rename
sdk.GetTracerProvidertosdk.TracerProvider; reason: https://go.dev/doc/effective_go#Getters - make a
v1release ofgo.opentelemetry.io/auto/sdk
XSAM
approved these changes
Oct 29, 2024
XSAM
reviewed
Oct 29, 2024
MrAlias
commented
Nov 21, 2024
pellared
approved these changes
Nov 21, 2024
Merged
MrAlias
added a commit
that referenced
this pull request
Dec 12, 2024
### Added - Add `Reset` method to `SpanRecorder` in `go.opentelemetry.io/otel/sdk/trace/tracetest`. (#5994) - Add `EnabledInstrument` interface in `go.opentelemetry.io/otel/sdk/metric/internal/x`. This is an experimental interface that is implemented by synchronous instruments provided by `go.opentelemetry.io/otel/sdk/metric`. Users can use it to avoid performing computationally expensive operations when recording measurements. It does not fall within the scope of the OpenTelemetry Go versioning and stability [policy](./VERSIONING.md) and it may be changed in backwards incompatible ways or removed in feature releases. (#6016) ### Changed - The default global API now supports full auto-instrumentation from the `go.opentelemetry.io/auto` package. See that package for more information. (#5920) - Propagate non-retryable error messages to client in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#5929) - Propagate non-retryable error messages to client in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#5929) - Propagate non-retryable error messages to client in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#5929) - Performance improvements for attribute value `AsStringSlice`, `AsFloat64Slice`, `AsInt64Slice`, `AsBoolSlice`. (#6011) - Change `EnabledParameters` to have a `Severity` field instead of a getter and setter in `go.opentelemetry.io/otel/log`. (#6009) ### Fixed - Fix inconsistent request body closing in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#5954) - Fix inconsistent request body closing in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#5954) - Fix inconsistent request body closing in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#5954) - Fix invalid exemplar keys in `go.opentelemetry.io/otel/exporters/prometheus`. (#5995) - Fix attribute value truncation in `go.opentelemetry.io/otel/sdk/trace`. (#5997) - Fix attribute value truncation in `go.opentelemetry.io/otel/sdk/log`. (#6032)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the auto-instrumentation attaches to a process using the global TracerProvider, and there has not been a delegate set, create a span from the go.opentelemetry.io/auto/sdk package so the OTel Go auto-instrumentation can instrument the application by default.
Resolve #5702
Benchmarks