-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WithExplicitBucketBoundaries Histogram option to the metric api #4603
Merged
MadVikingGod
merged 9 commits into
open-telemetry:main
from
dashpole:explicit_bucket_advisory
Oct 26, 2023
Merged
Add WithExplicitBucketBoundaries Histogram option to the metric api #4603
MadVikingGod
merged 9 commits into
open-telemetry:main
from
dashpole:explicit_bucket_advisory
Oct 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
added
area:metrics
Part of OpenTelemetry Metrics
pkg:API
Related to an API package
enhancement
New feature or request
labels
Oct 10, 2023
dashpole
force-pushed
the
explicit_bucket_advisory
branch
from
October 10, 2023 19:30
df9521e
to
3972b9f
Compare
Codecov Report
@@ Coverage Diff @@
## main #4603 +/- ##
======================================
Coverage 81.4% 81.4%
======================================
Files 225 225
Lines 17728 17830 +102
======================================
+ Hits 14431 14529 +98
- Misses 2998 3001 +3
- Partials 299 300 +1
|
dashpole
force-pushed
the
explicit_bucket_advisory
branch
3 times, most recently
from
October 10, 2023 19:39
9871661
to
67f421e
Compare
dashpole
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
October 10, 2023 19:51
pellared
reviewed
Oct 10, 2023
pellared
approved these changes
Oct 11, 2023
MrAlias
approved these changes
Oct 12, 2023
dashpole
force-pushed
the
explicit_bucket_advisory
branch
from
October 12, 2023 15:12
f98fb01
to
983a7c7
Compare
dashpole
force-pushed
the
explicit_bucket_advisory
branch
from
October 12, 2023 15:13
983a7c7
to
8fb33f3
Compare
MadVikingGod
approved these changes
Oct 13, 2023
Just to double-check. Can we merge this PR? 😉 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:metrics
Part of OpenTelemetry Metrics
enhancement
New feature or request
pkg:API
Related to an API package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4094
I split the API changes into its own PR so we can discuss them independently. There are a few choices we have:
One option or two (for int vs float)
Single Option (proposed):
VS
[]float64 vs ...float64
UX of
...float64
(proposed)UX of []float64: