Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Histogram Support to STDOUT Exporter #954

Closed
MrAlias opened this issue Jul 21, 2020 · 4 comments
Closed

Add Histogram Support to STDOUT Exporter #954

MrAlias opened this issue Jul 21, 2020 · 4 comments
Assignees
Labels
area:metrics Part of OpenTelemetry Metrics enhancement New feature or request pkg:exporter:stdout Related to the stdout exporter package
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jul 21, 2020

The aggregation should be output with the bucket/count pairs being displayed to the user.

@MrAlias MrAlias added enhancement New feature or request good first issue Good for newcomers pkg:exporter area:metrics Part of OpenTelemetry Metrics and removed good first issue Good for newcomers labels Jul 21, 2020
@MrAlias MrAlias self-assigned this Jul 21, 2020
@mujtaba-ahmed12
Copy link
Contributor

@MrAlias I would like to take this issue.

@jmacd
Copy link
Contributor

jmacd commented Jul 23, 2020

This could use the format embraced by Prometheus for the boundaries as "le" labels.

The upper boundary at 1 is encoded as a label "le=1" in this scheme.

@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 23, 2020

This could use the format embraced by Prometheus for the boundaries as "le" labels.

The upper boundary at 1 is encoded as a label "le=1" in this scheme.

Given our existing JSON structure here I had originally though something like:

type expoLine struct {
	Name      string      `json:"name"`
...
	Histogram []bucket    `json:"histogram,omitempty"`
}

type boundary struct {
	Min float64 `json:"min"`
	Max float64 `json:"max"`
}

type bucket struct {
	boundary `json:"bounds"`
	Count    float64 `json:"count"`
}

But, I wonder if we couldn't also have a form of the exporter export prometheus metrics. They are text based and well known.

Maybe add as option like PrettyPrint?

@MrAlias MrAlias removed their assignment Jul 24, 2020
@MrAlias MrAlias linked a pull request Aug 20, 2020 that will close this issue
@MrAlias MrAlias added this to the RC1 milestone Aug 27, 2020
@MrAlias MrAlias removed this from the RC1 milestone Feb 12, 2021
@MrAlias MrAlias added pkg:exporter:stdout Related to the stdout exporter package and removed pkg:exporter labels Apr 6, 2021
@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 12, 2022

Resolved by #3175

@MrAlias MrAlias closed this as completed Oct 12, 2022
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics enhancement New feature or request pkg:exporter:stdout Related to the stdout exporter package
Projects
None yet
Development

No branches or pull requests

4 participants