Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align opentelemetry instrumentation naming with specification #780

Closed
toumorokoshi opened this issue May 30, 2020 · 0 comments · Fixed by #779
Closed

align opentelemetry instrumentation naming with specification #780

toumorokoshi opened this issue May 30, 2020 · 0 comments · Fixed by #779

Comments

@toumorokoshi
Copy link
Member

Hi!

I recently worked with opentelemetry-specification to align on a standardized naming for instrumentations across languages. Here's the final result:

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/overview.md#instrumentation-libraries

And the PR where it was discussed:

open-telemetry/opentelemetry-specification#539

I think if go followed the specification as written, it would have packages renamed from "plugin" to "instrumentation":

https://github.com/open-telemetry/opentelemetry-go/tree/master/plugin

I'm filing this issue for awareness and discussion, and happy to collect and raise questions to the spec or technical committee.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename plugin directory to instrumentation MrAlias/opentelemetry-go
1 participant
@toumorokoshi