Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the Logger configuration #4911

Closed
10 tasks done
Tracked by #3827
MrAlias opened this issue Feb 12, 2024 · 0 comments · Fixed by #4937
Closed
10 tasks done
Tracked by #3827

Implement the Logger configuration #4911

MrAlias opened this issue Feb 12, 2024 · 0 comments · Fixed by #4937
Assignees
@MrAlias
Labels
area:logs Part of OpenTelemetry logs
Milestone
v1.24.0/v0.46.0

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Feb 12, 2024 •
edited
Loading

reference: https://github.com/open-telemetry/opentelemetry-go/pull/4725/files#diff-5f08160c94b60c7d075209bbd3ec93f7af5e044ef67016c74e462acefd3ec6fdR30-R103

  • Implement LoggerConfig
    • Ensure this type is not comparable
    • InstrumentationVersion method
    • InstrumentationAttributes method
    • SchemaURL method
    • NewLoggerConfig creation function
  • WithInstrumentationVersion
  • WithInstrumentationAttributes
  • WithInstrumentationAttributes
  • Add tests to cover all added functionality
@MrAlias MrAlias mentioned this issue Feb 12, 2024
Closed
11 tasks
@MrAlias MrAlias changed the title Implement the LoggerConfig Implement the Logger configuration Feb 12, 2024
@MrAlias MrAlias mentioned this issue Feb 12, 2024
Merged
@MrAlias MrAlias added the area:logs Part of OpenTelemetry logs label Feb 12, 2024
@MrAlias MrAlias self-assigned this Feb 16, 2024
@MrAlias MrAlias mentioned this issue Feb 16, 2024
Merged
@MrAlias MrAlias added this to the v1.24.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:logs Part of OpenTelemetry logs
Projects
Go: Logs (GA)
Status: Done
Milestone
v1.24.0/v0.46.0
Development

Successfully merging a pull request may close this issue.

Implement the LoggerConfig and add the LoggerOptions MrAlias/opentelemetry-go
1 participant
@MrAlias