Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate v1.23.0 semconv #4744

Closed
pellared opened this issue Dec 5, 2023 · 5 comments · Fixed by #4746
Closed

Generate v1.23.0 semconv #4744

pellared opened this issue Dec 5, 2023 · 5 comments · Fixed by #4746
Assignees
@pellared
Milestone
v1.22.0

Comments

@pellared
Copy link
Member

pellared commented Dec 5, 2023 •
edited
Loading

https://github.com/open-telemetry/opentelemetry-specification/releases/tag/v1.23.0
@pellared
Copy link
Member Author

pellared commented Dec 5, 2023 •
edited
Loading

Does it make sense to do it if there is a bug in v1.23.0 and v1.23.1 was released?

Reference: #4745

@pellared pellared changed the title Generate v1.22.0 semconv Generate v1.23.0 semconv Dec 5, 2023
@pellared pellared mentioned this issue Dec 6, 2023
Merged
@MrAlias
Copy link
Contributor

MrAlias commented Dec 6, 2023

Does it make sense to do it if there is a bug in v1.23.0 and v1.23.1 was released?

Reference: #4745

If v1.23.0 was redacted, then no. This was the case of v1.6.0.

If v1.23.0 wasn't redacted, then maybe not(?).

@MrAlias
Copy link
Contributor

MrAlias commented Dec 6, 2023

Release link for semconv repo:

@MrAlias
Copy link
Contributor

MrAlias commented Dec 6, 2023

It looks like the patch was to address the build tooling not working. If we are able to generate the release it seems like we are not hit by the bug.

@pellared
Copy link
Member Author

pellared commented Dec 6, 2023

I agree that is also why I decided to create a PR. @MrAlias thanks for double-checking.

@MrAlias MrAlias added this to the v1.22.0 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
None yet
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging a pull request may close this issue.

Add semconv/v1.23.0 pellared/opentelemetry-go
2 participants
@pellared @MrAlias