Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregator_example_test.go is out of date. #4331

Closed
MadVikingGod opened this issue Jul 17, 2023 · 1 comment · Fixed by #4334
Closed

aggregator_example_test.go is out of date. #4331

MadVikingGod opened this issue Jul 17, 2023 · 1 comment · Fixed by #4334
Labels
enhancement New feature or request

Comments

@MadVikingGod
Copy link
Contributor

MadVikingGod commented Jul 17, 2023

Problem Statement

aggregator_example_test.go is out of date and doesn't represent how aggregators are built and used anymore.

Proposed Solution

Update the example to show how these aggregations are currently built.

Alternatives

Remove this example.

Additional Context

I believe this file was made before the meter had a pipeline structure. This was an example of how the Meter/MeterProvider might use the Aggregations. Now that the pipeline exists, I question if this still provides us value, especially if we can fundamentally change the use of Aggregators and not have this break.

@MadVikingGod MadVikingGod added the enhancement New feature or request label Jul 17, 2023
@MrAlias
Copy link
Contributor

MrAlias commented Jul 17, 2023

Remove this example.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants