Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an error with the multi-callback #3573

Closed
MrAlias opened this issue Jan 6, 2023 · 0 comments · Fixed by #3576
Closed

Return an error with the multi-callback #3573

MrAlias opened this issue Jan 6, 2023 · 0 comments · Fixed by #3576
Assignees
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jan 6, 2023

If we are going to return errors with the individual callback, should we also look at returning an error with the multi-callback (via RegisterCallback)? This would allow us to unify the logic under the hood to have a single collection of callbacks that need executing, because individual callbacks can be converted into multi-callbacks. (follow up is fine)

Originally posted by @MadVikingGod in #3507 (review)

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Jan 6, 2023
@github-project-automation github-project-automation bot moved this to Triage Needed in Go: Metric API (GA) Jan 6, 2023
@MrAlias MrAlias added this to the Metric v0.35.0 milestone Jan 6, 2023
@MrAlias MrAlias moved this from Triage Needed to Blocked in Go: Metric API (GA) Jan 6, 2023
@MrAlias MrAlias self-assigned this Jan 6, 2023
@MrAlias MrAlias moved this from Blocked to In Progress in Go: Metric API (GA) Jan 6, 2023
@MrAlias MrAlias moved this to In Progress in Go: Metric SDK (Beta) Jan 6, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: Metric SDK (Beta) Jan 8, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: Metric API (GA) Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant