Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify treatment of unspecified values in Metrics export pipeline #320

Closed
jmacd opened this issue Nov 14, 2019 · 2 comments
Closed

Clarify treatment of unspecified values in Metrics export pipeline #320

jmacd opened this issue Nov 14, 2019 · 2 comments
Assignees
Labels
area:metrics Part of OpenTelemetry Metrics blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made

Comments

@jmacd
Copy link
Contributor

jmacd commented Nov 14, 2019

This was discussed in #265, see this comment: #265 (comment)

The current otel-proto declares that unspecified values will be exported as empty strings. The question for the SDK is whether the exporters should be able to distinguish unspecified from empty strings. It could be accomplished by using the core.Value INVALID type, but the fix is not trivial because label encoders will need a way to represent unspecified.

@rghetia rghetia added the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Dec 5, 2019
@jmacd jmacd added the area:metrics Part of OpenTelemetry Metrics label Dec 12, 2019
@rghetia rghetia added this to the Alpha v0.3 milestone Feb 13, 2020
@jmacd
Copy link
Contributor Author

jmacd commented Mar 4, 2020

It has been discussed in the 2/27/20 Metrics SIG and I believe we have converged on treating the empty value as equivalent to the unspecified value.

As motivational evidence, note this line in the Prometheus documentation:

A label with an empty label value is considered equivalent to a label that does not exist.

This means that we should change the SDK's Meter.Labels(...) to drop empty-string values from the label set.

@jmacd
Copy link
Contributor Author

jmacd commented Mar 5, 2020

The clarification is here: #345

We'll keep the current behavior, in other words, closing this.

@jmacd jmacd closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants