Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block release until the scope attribute specification issue is resolved #3145

Closed
MrAlias opened this issue Sep 6, 2022 · 5 comments
Closed
Assignees

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Sep 6, 2022

open-telemetry/opentelemetry-specification#2762

@MrAlias MrAlias added this to the Release v1.10.0 milestone Sep 6, 2022
@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 8, 2022

We plan to revert the addition of scope attributes, make the release, and add them back in right after the release (to be released in v1.11.0).

@MrAlias MrAlias changed the title Block v1.10.0 release until the specification resolves issue Block v1.10.0 release until the scope attribute specification resolves issue Sep 8, 2022
@MadVikingGod
Copy link
Contributor

Opened #3154 to allow us to not block the v1.10 release. When that is merged we can move this to the 1.11 milestone.

@MrAlias MrAlias changed the title Block v1.10.0 release until the scope attribute specification resolves issue Block release until the scope attribute specification issue is resolved Sep 8, 2022
@MadVikingGod
Copy link
Contributor

The reverts are in, moving this to the 1.11 release.

@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 15, 2022

From SIG meeting today:

  • This should not block a release until the specification that includes these changes has been released.
  • The spec changes, currently, look to only require the API accept attributes at Tracer/Meter/Logger creation. The SDK, it seems, is not yet required to handle/export these. A possible resolution to this issue would be to add the Meter/Tracer WithScopeAttributes options back but nothing more (including not adding them to the configs).
  • Another option would be to chose a behavior we think close to what the specification will eventually include and build that in. That way users will be able to export scope attributes (dropping these attributes will likely be a pain point for users.

@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 19, 2022

The upstream issue is closed and it doesn't look like there is a plan to add the attributes back as identifying. Given we have removed our implementation as well I'm going to close this issue as the release should not be blocked by this.

@MrAlias MrAlias closed this as completed Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@MadVikingGod @MrAlias and others