Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sdk/metric/export package to sdk/metric/metricdata #3013

Closed
MrAlias opened this issue Jul 12, 2022 · 1 comment · Fixed by #3014
Closed

Rename sdk/metric/export package to sdk/metric/metricdata #3013

MrAlias opened this issue Jul 12, 2022 · 1 comment · Fixed by #3014
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jul 12, 2022

Currently the sdk/metric/export package contains the data types that metric telemetry are represented by.

The name of this package is problematic. It is not uniquely descriptive of its contents and it conflicts with other packages we have previously published 1 2.

Another proposal was to use the package name sdk/metric/data. This name still does not effectively represent the contents of the package as being related to metrics. It has a high probability of colliding with other data type packages we will add in the future.

I propose we rename it to sdk/metric/metricdata. This follows other "test" package names (e.g. http/httptest), but instead will refer to fact that package contains data types related to metrics.

Footnotes

  1. https://pkg.go.dev/go.opentelemetry.io/otel/sdk/export

  2. https://pkg.go.dev/go.opentelemetry.io/otel/sdk/[email protected]/export

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Jul 12, 2022
@MrAlias MrAlias moved this from Todo to Blocked in OpenTelemetry Go: Metric SDK (Alpha) Jul 12, 2022
@MrAlias MrAlias added this to the Metric SDK: Alpha milestone Jul 12, 2022
@hanyuancheung
Copy link
Member

done with #3014

Repository owner moved this from Blocked to Done in OpenTelemetry Go: Metric SDK (Alpha) Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants