Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MeterProvider Options #2819

Closed
2 tasks done
MrAlias opened this issue Apr 19, 2022 · 2 comments · Fixed by #2905
Closed
2 tasks done

Implement MeterProvider Options #2819

MrAlias opened this issue Apr 19, 2022 · 2 comments · Fixed by #2905
Assignees
@MrAlias
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Milestone
Metric SDK: Alpha

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 19, 2022 •
edited
Loading

  • WithResource
  • WithReader

Blocked by #2800, #2817, #2809
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Apr 19, 2022
@MrAlias MrAlias added this to the Metric SDK: Alpha milestone Apr 19, 2022
@MrAlias MrAlias moved this from Blocked to Todo in OpenTelemetry Go: Metric SDK (Alpha) May 13, 2022
@MrAlias MrAlias self-assigned this May 13, 2022
@MrAlias MrAlias moved this from Todo to In Progress in OpenTelemetry Go: Metric SDK (Alpha) May 13, 2022
@MrAlias
Copy link
Contributor Author

MrAlias commented May 13, 2022

Based on prior discussions, it seems like we want to associate views with readers. I'm planing a PR to propose:

func WithResource(res *resource.Resource) Option

func WithReader(r Reader, opts ...view.Option) Option

As found here.

@MrAlias MrAlias mentioned this issue May 16, 2022
Merged
@MrAlias MrAlias linked a pull request May 17, 2022 that will close this issue
Add WithReader and WithResource Options #2905
Merged
@MrAlias
Copy link
Contributor Author

MrAlias commented May 21, 2022

Closed by #2905

@MrAlias MrAlias closed this as completed May 21, 2022
Repository owner moved this from In Progress to Done in OpenTelemetry Go: Metric SDK (Alpha) May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
OpenTelemetry Go: Metric SDK (Alpha)
Status: Done
Milestone
Metric SDK: Alpha
Development

Successfully merging a pull request may close this issue.

Add WithReader and WithResource Options MrAlias/opentelemetry-go
1 participant
@MrAlias