Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sdk/metric/sdkinstrument package to new_sdk/main #2813

Closed
MrAlias opened this issue Apr 19, 2022 · 4 comments
Closed

Add sdk/metric/sdkinstrument package to new_sdk/main #2813

MrAlias opened this issue Apr 19, 2022 · 4 comments
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Milestone
Metric SDK: Alpha

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 19, 2022 •
edited
Loading

This may not need to live in it's own package. Otherwise, we should try and find naming that does not include the term sdk (that is already a part of the package import path).
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Apr 19, 2022
@MrAlias MrAlias added this to the Metric SDK: Alpha milestone Apr 19, 2022
@MrAlias MrAlias mentioned this issue Apr 19, 2022
Closed
2 tasks
@MrAlias MrAlias moved this from Blocked to Todo in OpenTelemetry Go: Metric SDK (Alpha) Apr 20, 2022
@MrAlias MrAlias mentioned this issue Apr 20, 2022
Closed
4 tasks
@MrAlias
Copy link
Contributor Author

MrAlias commented Apr 20, 2022

I'm guessing the naming choice comes from the desire to not collide with the API package "go.opentelemetry.io/otel/metric/instrument".

@MrAlias
Copy link
Contributor Author

MrAlias commented Apr 21, 2022

I would purpose we rename this to instrument from there...

  • Merge the number package into this.
    • Rename the number.Number type to instrument.Value
  • Move the Metrics, Scope, Instrument, Points types from the reader package to here. They all seem related to metric instruments and seem better fit here.

@MadVikingGod
Copy link
Contributor

Additionally when NumberKind and InstrumentKind are defined views will need to be able to Match based on them.

@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 7, 2022

This is not needed anymore.

@MrAlias MrAlias closed this as completed Jul 7, 2022
Repository owner moved this from Todo to Done in OpenTelemetry Go: Metric SDK (Alpha) Jul 7, 2022
@MadVikingGod MadVikingGod mentioned this issue Jul 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
OpenTelemetry Go: Metric SDK (Alpha)
Status: Done
Milestone
Metric SDK: Alpha
Development

No branches or pull requests
2 participants
@MadVikingGod @MrAlias