Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the sdk/export/metric package #2273

Closed
jmacd opened this issue Oct 1, 2021 · 2 comments
Closed

Remove the sdk/export/metric package #2273

jmacd opened this issue Oct 1, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone
untracked

Comments

@jmacd
Copy link
Contributor

jmacd commented Oct 1, 2021

Problem Statement

As with #1380, but for the metrics SDK.

Proposed Solution

The types in sdk/export/metric will be moved into sdk/metric/exporter, sdk/metric/processor, and sdk/metric/aggregator in such a way as to avoid cycles and keep things in their most natural location. The sub-package aggregation will be merged with sdk/metric/aggregator.

Alternatives

None.

Prior Art

See #1380.

Additional Context

Related: the ExportKind types will end up in the processor package which is why I want to rename them first, see #2272
@jmacd jmacd added the enhancement New feature or request label Oct 1, 2021
@jmacd jmacd mentioned this issue Oct 1, 2021
Merged
@MovieStoreGuy
Copy link

MovieStoreGuy commented Oct 21, 2021 •
edited
Loading

Could we also make sure to comment that these packages are deprecated as well to avoid confusion when trying to adopt?

This was referenced Oct 21, 2021
Closed
Closed
Closed
@jmacd jmacd mentioned this issue Nov 15, 2021
Merged
This was referenced Dec 13, 2021
Merged
Merged
@MrAlias
Copy link
Contributor

MrAlias commented May 3, 2022

Resolved by #2382

@MrAlias MrAlias closed this as completed May 3, 2022
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
untracked
Development

No branches or pull requests
4 participants
@jmacd @pellared @MrAlias @MovieStoreGuy