Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTLP metrics exporter UploadMetrics signature change #2228

Closed
jmacd opened this issue Sep 8, 2021 · 1 comment · Fixed by #2491
Closed

OTLP metrics exporter UploadMetrics signature change #2228

jmacd opened this issue Sep 8, 2021 · 1 comment · Fixed by #2491
Labels
enhancement New feature or request
Milestone
untracked

Comments

@jmacd
Copy link
Contributor

jmacd commented Sep 8, 2021

Problem Statement

The UploadMetrics() call takes a []*metricpb.ResourceMetrics despite only ever receiving a single Resource. The code can change accordingly.

#2197 (comment)

Proposed Solution

A small change in a separate PR from #2197.
@jmacd jmacd added the enhancement New feature or request label Sep 8, 2021
@jmacd jmacd mentioned this issue Sep 8, 2021
Merged
@hanyuancheung hanyuancheung mentioned this issue Jan 2, 2022
Merged
2 tasks
@jmacd
Copy link
Contributor Author

jmacd commented Jan 4, 2022

🎉

@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

change UploadMetrics signature from slice to single Resource hanyuancheung/opentelemetry-go
2 participants
@jmacd @pellared