Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporters/trace/jaeger test compilation error #1576

Closed
MrAlias opened this issue Feb 23, 2021 · 0 comments · Fixed by #1577
Closed

exporters/trace/jaeger test compilation error #1576

MrAlias opened this issue Feb 23, 2021 · 0 comments · Fixed by #1577
Assignees
Labels
bug Something isn't working
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Feb 23, 2021

Testing on Windows (Go 1.15 arch=amd64):

# go.opentelemetry.io/otel/exporters/trace/jaeger [go.opentelemetry.io/otel/exporters/trace/jaeger.test]
Error: .\reconnecting_udp_client_test.go:87:45: cannot use int(fd.Fd()) (type int) as type syscall.Handle in argument to syscall.GetsockoptInt
FAIL	go.opentelemetry.io/otel/exporters/trace/jaeger [build failed]

I am able to reproduce this locally on a linux system:

$ cd exporters/trace/jaeger
$ GOOS=windows go test .
# go.opentelemetry.io/otel/exporters/trace/jaeger [go.opentelemetry.io/otel/exporters/trace/jaeger.test]
./reconnecting_udp_client_test.go:87:45: cannot use int(fd.Fd()) (type int) as type syscall.Handle in argument to syscall.GetsockoptInt
FAIL	go.opentelemetry.io/otel/exporters/trace/jaeger [build failed]
FAIL

It looks like we use the low level syscall package with a unix specific calling signature:

bufferBytes, _ := syscall.GetsockoptInt(int(fd.Fd()), syscall.SOL_SOCKET, syscall.SO_SNDBUF)

The unix function signature for syscall.GetsockoptInt:

func GetsockoptInt(fd, level, opt int) (value int, err error)

Where the windows signature is:

func GetsockoptInt(fd Handle, level, opt int) (int, error)
@MrAlias MrAlias added bug Something isn't working pkg:exporter labels Feb 23, 2021
@MrAlias MrAlias self-assigned this Feb 23, 2021
@pellared pellared moved this to Closed in Go: Triage Nov 2, 2023
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants