-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI and build tools #1523
Comments
please build linux/arm64 as well please, and I think we can drop linux/386 |
Added to the list 👍 |
FWIW, I made the subjective selection on OS/arch from this list:
|
Looking into testing arm or arm64 on the GitHub Actions platform I discovered that we will need to build and maintain our own runners. This does not sound like something we should invest in at this point. I'm planning to keep trying to test the 386 architecture at this point to ensure we are testing a 32 bit architecture. |
Do we need 32-bit Windows and Mac? They are not that common anymore, especially in our target audience. I'd focus on the following initially:
|
We do not need to focus on the darwin/386 as that is indeed an invalid OS/ARCH pair. As for |
I'm okay with not running the tests, but we should still ensure that our example binaries compile with GOARCH, just to make sure no weird stuff slips in. |
Would running via https://github.com/marketplace/actions/arm-runner be an option? |
As we move to a stable release of this project it would be ideal if we can assert confidence that this project will work on more than just linux systems with x86 or 386 CPU architecture. Additionally, it would be ideal if we could speed up the CI process.
I think a good example will be what the collector and collector-contrib has done:
The text was updated successfully, but these errors were encountered: