Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move generated OTLP to OTLP exporter #1045

Closed
MrAlias opened this issue Aug 7, 2020 · 1 comment · Fixed by #1050
Closed

Move generated OTLP to OTLP exporter #1045

MrAlias opened this issue Aug 7, 2020 · 1 comment · Fixed by #1050
Assignees
@MrAlias
Labels
pkg:API Related to an API package
Milestone
untracked

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Aug 7, 2020

The generated protobuf currently lives in the top level otel internal package. This mean that the API will always depend on github.com/golang/protobuf and google.golang.org/grpc. These are large dependencies that we are trying to remove to achieve our goal of having the API be a lightweight dependency for instrumentors (#940).

The only current use of this code is in the OTLP exporter. They should be moved to this module.
@MrAlias MrAlias added pkg:API Related to an API package pkg:exporter labels Aug 7, 2020
@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 7, 2020

From what I can tell, this might be the last issue that needs to be resolved (after #973) before #940 can be resolved.

@MrAlias MrAlias changed the title Move generated OTLP to SDK Move generated OTLP to OTLP exporter Aug 10, 2020
@MrAlias MrAlias self-assigned this Aug 10, 2020
@MrAlias MrAlias mentioned this issue Aug 10, 2020
Merged
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
pkg:API Related to an API package
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

Move OTLP to the OTLP exporter MrAlias/opentelemetry-go
2 participants
@pellared @MrAlias