Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil sampling config #1292

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

RonFed
Copy link
Contributor

@RonFed RonFed commented Nov 13, 2024

An implementation of the ConfigProvider interface might provide configurations that don't specify a sampler.

  • For the initial configuration, the NewSamplingManager function is used - where a default config will be used if non is present.
  • For an update in configuration the applyConfig function will be used (this is not fully implemented yet in the main manager). In that case, the ConfigLoop handler will avoid calling the sampling applyConfig if no config was provided - this will make that update a no-op for sampling. For this reason, the applyConfig function is changed to return an error if a nil config is provided.

CHANGELOG.md Outdated Show resolved Hide resolved
@RonFed RonFed merged commit e316695 into open-telemetry:main Nov 18, 2024
27 checks passed
@RonFed RonFed deleted the nil_sampling_config branch November 18, 2024 10:08
@MrAlias MrAlias added this to the v0.18.0-alpha milestone Nov 19, 2024
@MrAlias MrAlias mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants