Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of the
ConfigProvider
interface might provide configurations that don't specify a sampler.NewSamplingManager
function is used - where a default config will be used if non is present.applyConfig
function will be used (this is not fully implemented yet in the main manager). In that case, theConfigLoop
handler will avoid calling the samplingapplyConfig
if no config was provided - this will make that update a no-op for sampling. For this reason, theapplyConfig
function is changed to return an error if a nil config is provided.