Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce e2e-test flakiness #972

Closed
RonFed opened this issue Jul 29, 2024 · 0 comments · Fixed by #1029
Closed

Reduce e2e-test flakiness #972

RonFed opened this issue Jul 29, 2024 · 0 comments · Fixed by #1029
Labels
enhancement New feature or request
Milestone

Comments

@RonFed
Copy link
Contributor

RonFed commented Jul 29, 2024

Some of the e2e tests (mainly the kafka-go one) are flaky. For example: https://github.com/open-telemetry/opentelemetry-go-instrumentation/actions/runs/10131243094/job/28013685717.
The cause for this failure is inconsistancy in the batch being exported. Since the default batch timeout is 5s, there is a probability of the spans being sent in 2 different batches/ single batch - which cause the differen JSON resullt in the test.

Proposed solutions:

  • The more straightforwrd solution is to define sample-job.yaml per e2e test. Each test will be able to configure the batch span processor using OTEL_BSP_MAX_EXPORT_BATCH_SIZE and OTEL_BSP_SCHEDULE_DELAY accoridng to the expected number of spans in the test.
  • A better solution might be to add a number_of_spans field to the test matrix defined in .
    This field will be used to configure OTEL_BSP_MAX_EXPORT_BATCH_SIZE per test. This will require to pass this config to sample-job. It might be possible through a build argument to the Dockerfile, and there are maybe more options.
@RonFed RonFed added the enhancement New feature or request label Jul 29, 2024
@MrAlias MrAlias added this to the v0.15.0-alpha milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants