Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gate for unstable/experimental libraries #776

Closed
damemi opened this issue Apr 10, 2024 · 1 comment
Closed

Add feature gate for unstable/experimental libraries #776

damemi opened this issue Apr 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@damemi
Copy link
Contributor

damemi commented Apr 10, 2024

Some of our instrumented libraries like database/sql and kafka currently rely on unstable semantic conventions. These should be put behind a feature gate that users have to explicitly enable in the agent for automatic instrumentation to pick up these libraries.

The reasoning for this is that users who expect automatic instrumentation may not be aware that the agent is using an experimental set of conventions for their library (due to the low investment of enabling automatic instrumentation).

So, when the conventions change, the users will be surprised by changes in their automatic instrumentation output. Putting this behind a feature gate draws their attention to the semantic conventions and makes them aware that this is likely to change.

@MrAlias
Copy link
Contributor

MrAlias commented Apr 23, 2024

Closing to consolidate the discussion in #785

@MrAlias MrAlias closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants