You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a package releases a patch version to a prior minor version the offsets generator does not evaluate that new patch version if a cached version range beyond the minor version exists. This means the offset for that patch version may be incorrect.
For example, google.golang.org/grpc just released v1.58.3. Our offsets for struct fields from that package include a range with a max greater than v1.58.X. For example,
When the offsets are "updated" the cached values are used and given 1.58.3 falls within that range the new offset is not detected, the cached value is used instead.
Possible solution
This may motivate moving back to the prior offsets format that listed each version explicitly (without version ranges).
When a package releases a patch version to a prior minor version the offsets generator does not evaluate that new patch version if a cached version range beyond the minor version exists. This means the offset for that patch version may be incorrect.
For example,
google.golang.org/grpc
just releasedv1.58.3
. Our offsets for struct fields from that package include a range with a max greater thanv1.58.X
. For example,opentelemetry-go-instrumentation/internal/pkg/inject/offset_results.json
Lines 51 to 72 in 31048ac
When the offsets are "updated" the cached values are used and given
1.58.3
falls within that range the new offset is not detected, the cached value is used instead.Possible solution
This may motivate moving back to the prior offsets format that listed each version explicitly (without version ranges).
Related PR
#45
The text was updated successfully, but these errors were encountered: