-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelgrpc: Deprecate interceptors in favor of stats handlers #4534
Merged
MrAlias
merged 4 commits into
open-telemetry:main
from
pellared:grpc-deprecate-interceptor
Nov 8, 2023
Merged
otelgrpc: Deprecate interceptors in favor of stats handlers #4534
MrAlias
merged 4 commits into
open-telemetry:main
from
pellared:grpc-deprecate-interceptor
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
otelgrpc: Deprecate interceptors in favor of stats handlers
[DoNotMerge] otelgrpc: Deprecate interceptors in favor of stats handlers
Nov 7, 2023
@fatsheep9146 Could you please review this PR? |
dashpole
approved these changes
Nov 8, 2023
pellared
changed the title
[DoNotMerge] otelgrpc: Deprecate interceptors in favor of stats handlers
otelgrpc: Deprecate interceptors in favor of stats handlers
Nov 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #4534 +/- ##
=======================================
- Coverage 80.8% 80.8% -0.1%
=======================================
Files 150 150
Lines 10371 10371
=======================================
- Hits 8387 8384 -3
- Misses 1840 1842 +2
- Partials 144 145 +1
|
MrAlias
approved these changes
Nov 8, 2023
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4318
We strongly still recommend you to use stats.Handler, mainly for two reasons.
Functional advantages: stats.Handler has more information for user to build more flexible and granular metric, for example:
Performance advantages: If too many interceptors are registered in a service, the interceptor chain can become too long, which increases the latency and processing time of the entire RPC call.