Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details on release process #59

Closed
evantorrie opened this issue Jun 8, 2020 · 0 comments · Fixed by #101
Closed

Add more details on release process #59

evantorrie opened this issue Jun 8, 2020 · 0 comments · Fixed by #101
Milestone

Comments

@evantorrie
Copy link
Contributor

Given that this contrib repo has a version dependency on the go.opentelemetry.io/otel repo as well as its own version (which may or may not be the same as the otel repo version), we likely need:

  • RELEASING.md
  • tag.sh
  • verify_examples.sh
    to ensure we release correctly tagged and verified releases.
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
This is to make tag.Map an immutable type, so it is safe to use
concurrently. The safety is not yet fully achieved because of the
functions returning contents of the map (Value and Foreach). The
functions give callers an access to core.Value objects, which contain
a byte slice, which has pointer like semantics. So to avoid accidental
changes, we will need to copy the value if it is of BYTES type.

Fixes #59
@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants