Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test in otelgrpc TestStatsHandler/ServerSpans #4416

Closed
pellared opened this issue Oct 11, 2023 · 5 comments
Closed

Flaky test in otelgrpc TestStatsHandler/ServerSpans #4416

pellared opened this issue Oct 11, 2023 · 5 comments
Assignees
@pellared
Labels
bug Something isn't working instrumentation: otelgrpc
Milestone
untracked

Comments

@pellared
Copy link
Member

https://github.com/open-telemetry/opentelemetry-go-contrib/actions/runs/6486518230/job/17614855539?pr=4414

go test -timeout 60s -short ./instrumentation/google.golang.org/grpc/otelgrpc/test/...
--- FAIL: TestStatsHandler (0.01s)
    --- FAIL: TestStatsHandler/ServerSpans (0.00s)
        grpc_stats_handler_test.go:321: 
            	Error Trace:	/home/runner/work/opentelemetry-go-contrib/opentelemetry-go-contrib/instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_stats_handler_test.go:321
            	            				/home/runner/work/opentelemetry-go-contrib/opentelemetry-go-contrib/instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_stats_handler_test.go:53
            	Error:      	"[%!s(*trace.snapshot=&{grpc.testing.TestService/EmptyCall {[148 231 6 191 1 82 236 223 239 236 142 215 58 219 190 15] [85 109 54 1 7 83 15 148] 1 {[]} false} {[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0] 0 {[]} true} 2 {13925649449016834626 3627144 0x8c35320} {13925649449016932427 3724945 0x8c35320} [{rpc.service {4 0 grpc.testing.TestService <nil>}} {rpc.method {4 0 EmptyCall <nil>}} {rpc.system {4 0 grpc <nil>}} {rpc.grpc.status_code {2 0  <nil>}}] [{message [{message.type {4 0 RECEIVED <nil>}} {message.id {2 1  <nil>}} {message.compressed_size {2 0  <nil>}} {message.uncompressed_size {2 0  <nil>}}] 0 {13925649449016866426 3658844 0x8c35320}} {message [{message.type {4 0 SENT <nil>}} {message.id {2 1  <nil>}} {message.compressed_size {2 0  <nil>}} {message.uncompressed_size {2 0  <nil>}}] 0 {13925649449016872926 3665344 0x8c35320}}] [] {0 } 0 0 0 0 0xa810b90 {go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc 0.45.0 }}) %!s(*trace.snapshot=&{grpc.testing.TestService/UnaryCall {[119 161 177 99 53 233 200 148 224 51 36 14 16 125 204 76] [65 113 140 85 101 113 215 67] 1 {[]} false} {[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0] 0 {[]} true} 2 {13925649449017613035 4405453 0x8c35320} {13925649449019231354 6023772 0x8c35320} [{rpc.service {4 0 grpc.testing.TestService <nil>}} {rpc.method {4 0 UnaryCall <nil>}} {rpc.system {4 0 grpc <nil>}} {rpc.grpc.status_code {2 0  <nil>}}] [{message [{message.type {4 0 RECEIVED <nil>}} {message.id {2 1  <nil>}} {message.compressed_size {2 271840  <nil>}} {message.uncompressed_size {2 271840  <nil>}}] 0 {13925649449018610547 5403065 0x8c35320}} {message [{message.type {4 0 SENT <nil>}} {message.id {2 1  <nil>}} {message.compressed_size {2 314167  <nil>}} {message.uncompressed_size {2 314167  <nil>}}] 0 {13925649449019225154 6017672 0x8c35320}}] [] {0 } 0 0 0 0 0xa810b90 {go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc 0.45.0 }}) %!s(*trace.snapshot=&{grpc.testing.TestService/StreamingOutputCall {[141 173 78 159 108 175 9 191 2 164 250 42 75 38 32 43] [165 97 28 9 144 43 39 168] 1 {[]} false} {[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0] 0 {[]} true} 2 {139256494490226652[95](https://github.com/open-telemetry/opentelemetry-go-contrib/actions/runs/6486518230/job/17614855539?pr=4414#step:6:96) 9457813 0x8c35320} {13925649449022839397 [96](https://github.com/open-telemetry/opentelemetry-go-contrib/actions/runs/6486518230/job/17614855539?pr=4414#step:6:97)31915 0x8c35320} [{rpc.service {4 0 grpc.testing.TestService <nil>}} {rpc.method {4 0 StreamingOutputCall <nil>}} {rpc.system {4 0 grpc <nil>}} {rpc.grpc.status_code {2 0  <nil>}}] [{message [{message.type {4 0 RECEIVED <nil>}} {message.id {2 1  <nil>}} {message.compressed_size {2 21  <nil>}} {message.uncompressed_size {2 21  <nil>}}] 0 {13925649449022679095 9471513 0x8c35320}} {message [{message.type {4 0 SENT <nil>}} {message.id {2 1  <nil>}} {message.compressed_size {2 31423  <nil>}} {message.uncompressed_size {2 31423  <nil>}}] 0 {13925649449022740295 9532813 0x8c35320}} {message [{message.type {4 0 SENT <nil>}} {message.id {2 2  <nil>}} {message.compressed_size {2 13  <nil>}} {message.uncompressed_size {2 13  <nil>}}] 0 {13925649449022743195 9535613 0x8c35320}} {message [{message.type {4 0 SENT <nil>}} {message.id {2 3  <nil>}} {message.compressed_size {2 2659  <nil>}} {message.uncompressed_size {2 2659  <nil>}}] 0 {13925649449022753796 9546314 0x8c35320}} {message [{message.type {4 0 SENT <nil>}} {message.id {2 4  <nil>}} {message.compressed_size {2 58987  <nil>}} {message.uncompressed_size {2 58987  <nil>}}] 0 {139256494490228352[97](https://github.com/open-telemetry/opentelemetry-go-contrib/actions/runs/6486518230/job/17614855539?pr=4414#step:6:98) 9627815 0x8c35320}}] [] {0 } 0 0 0 0 0xa810b90 {go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc 0.45.0 }}) %!s(*trace.snapshot=&{grpc.testing.TestService/FullDuplexCall {[230 172 142 225 22 211 177 86 19 96 113 164 1 97 152 153] [76 161 101 175 118 175 99 16] 1 {[]} false} {[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0] 0 {[]} true} 2 {13925649449023203701 9996219 0x8c35320} {13925649449024046311 10838829 0x8c35320} [{rpc.service {4 0 grpc.testing.TestService <nil>}} {rpc.method {4 0 FullDuplexCall <nil>}} {rpc.system {4 0 grpc <nil>}} {rpc.grpc.status_code {2 0  <nil>}}] [{message [{message.type {4 0 RECEIVED <nil>}} {message.id {2 1  <nil>}} {message.compressed_size {2 27196  <nil>}} {message.uncompressed_size {2 27196  <nil>}}] 0 {13925649449023311402 10103920 0x8c35320}} {message [{message.type {4 0 SENT <nil>}} {message.id {2 1  <nil>}} {message.compressed_size {2 31423  <nil>}} {message.uncompressed_size {2 31423  <nil>}}] 0 {13925649449023365703 10158121 0x8c35320}} {message [{message.type {4 0 RECEIVED <nil>}} {message.id {2 2  <nil>}} {message.compressed_size {2 16  <nil>}} {message.uncompressed_size {2 16  <nil>}}] 0 {13925649449023462904 10255422 0x8c35320}} {message [{message.type {4 0 SENT <nil>}} {message.id {2 2  <nil>}} {message.compressed_size {2 13  <nil>}} {message.uncompressed_size {2 13  <nil>}}] 0 {13925649449023465504 10258022 0x8c35320}} {message [{message.type {4 0 RECEIVED <nil>}} {message.id {2 3  <nil>}} {message.compressed_size {2 1839  <nil>}} {message.uncompressed_size {2 1839  <nil>}}] 0 {13925649449023503004 10295522 0x8c35320}} {message [{message.type {4 0 SENT <nil>}} {message.id {2 3  <nil>}} {message.compressed_size {2 2659  <nil>}} {message.uncompressed_size {2 2659  <nil>}}] 0 {13925649449023508305 10300723 0x8c35320}} {message [{message.type {4 0 RECEIVED <nil>}} {message.id {2 4  <nil>}} {message.compressed_size {2 45918  <nil>}} {message.uncompressed_size {2 45918  <nil>}}] 0 {13925649449023783608 10576126 0x8c35320}} {message [{message.type {4 0 SENT <nil>}} {message.id {2 4  <nil>}} {message.compressed_size {2 58[98](https://github.com/open-telemetry/opentelemetry-go-contrib/actions/runs/6486518230/job/17614855539?pr=4414#step:6:99)7  <nil>}} {message.uncompressed_size {2 58987  <nil>}}] 0 {13925649449023883509 10676027 0x8c35320}}] [] {0 } 0 0 0 0 0xa810b90 {go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc 0.45.0 }})]" should have 5 item(s), but has 4
            	Test:       	TestStatsHandler/ServerSpans
FAIL
FAIL	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/test	6.039s
@pellared
Copy link
Member Author

@fatsheep9146 Can you please take a look at this issue?

@pellared pellared added bug Something isn't working instrumentation: otelgrpc labels Oct 11, 2023
@pellared pellared mentioned this issue Oct 11, 2023
Merged
@fatsheep9146
Copy link
Contributor

fatsheep9146 commented Oct 11, 2023 •
edited
Loading

@fatsheep9146 Can you please take a look at this issue?

No problem, I will look at this @pellared

@pellared
Copy link
Member Author

I would not be surprised if the root cause of the problem is the same as for #1352

@fatsheep9146
Copy link
Contributor

I would not be surprised if the root cause of the problem is the same as for #1352

Yes, they must be caused by same reason

@liufuyang liufuyang mentioned this issue Oct 26, 2023
Merged
@pellared pellared mentioned this issue Nov 6, 2023
Merged
@pellared pellared assigned pellared and unassigned fatsheep9146 Nov 6, 2023
@pellared
Copy link
Member Author

pellared commented Nov 6, 2023

Should be fixed by be618e6

@pellared pellared closed this as completed Nov 6, 2023
@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
bug Something isn't working instrumentation: otelgrpc
Projects
None yet
Milestone
untracked
Development

No branches or pull requests
2 participants
@pellared @fatsheep9146