Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgrpc: Remove the interceptors #4319

Open
pellared opened this issue Sep 18, 2023 · 0 comments
Open

otelgrpc: Remove the interceptors #4319

pellared opened this issue Sep 18, 2023 · 0 comments
Labels
area: instrumentation Related to an instrumentation package instrumentation: otelgrpc

Comments

@pellared
Copy link
Member

pellared commented Sep 18, 2023

I think we should also update the existing examples to use the new instrumentation.

I propose to:

  1. Merge this PR
  2. Create an issue for https://github.com/open-telemetry/opentelemetry-go-contrib/pull/3002/files#r1209293763
  3. Update the existing examples to use the new functionality.
  4. Deprecate the interceptors so that they are available in next release.
  5. After the next release remove the interceptors.

@open-telemetry/go-approvers please upvote/downvote if you agree or not. Feel free to leave any additional feedback.

Originally posted by @pellared in #3002 (review)

Remove the interceptors after the deprecation is part of a release.

EDIT: We should still have the interceptors (even as deprecated) as long as https://pkg.go.dev/google.golang.org/grpc/stats is experimental API.

Blocked by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package instrumentation: otelgrpc
Projects
None yet
Development

No branches or pull requests

2 participants