Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelhttp.WithRouteTag should update the span name #4018

Open
pellared opened this issue Jun 22, 2023 · 1 comment
Open

otelhttp.WithRouteTag should update the span name #4018

pellared opened this issue Jun 22, 2023 · 1 comment
Assignees
@pellared

Comments

@pellared
Copy link
Member

Would it not be good to also update the span name?

See: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#name

Originally posted by @pellared in #4017 (comment)
@pellared pellared mentioned this issue Jun 22, 2023
Closed
@pellared pellared self-assigned this Jun 22, 2023
@pellared
Copy link
Member Author

Problems that I encountered when I started to implement it.

  1. The name (and documentation) of WithRouteTag suggests that it is only about the "tag" (it should be "attribute" (sic!). I am considering to make a breaking change and rename it to WithRoute.
  2. Is it OK if WithRouteTag has precedence over WithSpanNameFormatter when setting the span name?

This was referenced Aug 9, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pellared