Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a codes conversion function for gRPCs instrumentation #295

Closed
MrAlias opened this issue Aug 25, 2020 · 1 comment
Closed

Create a codes conversion function for gRPCs instrumentation #295

MrAlias opened this issue Aug 25, 2020 · 1 comment
Labels
blocked: specification Waiting on clarification of the OpenTelemetry specification before progress can be made enhancement New feature or request
Milestone
RC1

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Aug 25, 2020

Similar to what the SDK does we need an internal conversion function for the google.golang.org/grpc instrumentation instead of assuming the underlying unit32 is the same:

https://github.com/open-telemetry/opentelemetry-go-contrib/pull/282/files#diff-e8efb286b388c2fecb39033f0fa2a88bR273
@MrAlias MrAlias mentioned this issue Aug 25, 2020
Merged
@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 26, 2020

This should be held off on until the state of a Span's Status is better known. open-telemetry/oteps#134

@MrAlias MrAlias added blocked: specification Waiting on clarification of the OpenTelemetry specification before progress can be made enhancement New feature or request priority:p2 labels Aug 26, 2020
@MrAlias MrAlias added this to the RC1 milestone Sep 3, 2020
@matej-g matej-g mentioned this issue Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked: specification Waiting on clarification of the OpenTelemetry specification before progress can be made enhancement New feature or request
Projects
None yet
Milestone
RC1
Development

No branches or pull requests
2 participants
@Aneurysm9 @MrAlias