Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run golangci-lint on Windows #451

Closed
pellared opened this issue Dec 6, 2023 · 3 comments
Closed

Run golangci-lint on Windows #451

pellared opened this issue Dec 6, 2023 · 3 comments

Comments

@pellared
Copy link
Member

pellared commented Dec 6, 2023 

internal\syncerror\known_sync_error_windows.go:27:9: comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
        return err == windows.ERROR_INVALID_HANDLE

Interesting, didn't know golangci-lint doesn't check go files for Windows when ran on unix systems (ci).

Originally posted by @scorpionknifes in #448 (comment)
@pellared
Copy link
Member Author

pellared commented Dec 6, 2023

Similar to #450

@pellared pellared mentioned this issue Dec 6, 2023
Merged
@pellared
Copy link
Member Author

pellared commented Dec 6, 2023 •
edited
Loading

Probably it can be run with GOOS=windows on Linux.

@scorpionknifes scorpionknifes mentioned this issue Dec 13, 2023
Merged
@pellared
Copy link
Member Author

Fixed by #466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pellared