From 6c49218c786900bdb84943fe3057bc1f82e1c54e Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Mon, 8 Aug 2022 20:39:45 -0700 Subject: [PATCH 1/2] Nit fixes to prometheus readme --- src/OpenTelemetry.Exporter.Prometheus.AspNetCore/README.md | 4 ++-- src/OpenTelemetry.Exporter.Prometheus.HttpListener/README.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/README.md b/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/README.md index d9cb8bfdc1a..f838f296ae8 100644 --- a/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/README.md +++ b/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/README.md @@ -16,14 +16,14 @@ to scrape. ### Step 1: Install Package ```shell -dotnet add package OpenTelemetry.Exporter.Prometheus.AspNetCore +dotnet add package --prerelease OpenTelemetry.Exporter.Prometheus.AspNetCore ``` ### Step 2: Configure OpenTelemetry MeterProvider * When using [OpenTelemetry.Extensions.Hosting](../OpenTelemetry.Extensions.Hosting/README.md) - package on .NET Core 3.1+: + package on .NET 6.0+: ```csharp services.AddOpenTelemetryMetrics(builder => diff --git a/src/OpenTelemetry.Exporter.Prometheus.HttpListener/README.md b/src/OpenTelemetry.Exporter.Prometheus.HttpListener/README.md index b97cb0bd258..882203b2d77 100644 --- a/src/OpenTelemetry.Exporter.Prometheus.HttpListener/README.md +++ b/src/OpenTelemetry.Exporter.Prometheus.HttpListener/README.md @@ -16,7 +16,7 @@ instance for Prometheus to scrape. ### Step 1: Install Package ```shell -dotnet add package OpenTelemetry.Exporter.Prometheus.HttpListener +dotnet add package --prerelease OpenTelemetry.Exporter.Prometheus.HttpListener ``` ### Step 2: Add PrometheusHttpListener From d607e6e51b0bf0e14869e196f8ceb4ceaa222fd5 Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Thu, 6 Oct 2022 21:14:25 -0700 Subject: [PATCH 2/2] Add minor clarification about OTLP logs --- .../README.md | 11 ++++++----- .../Metrics/MetricReaderTemporalityPreference.cs | 2 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md b/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md index 5a2630438f7..b992147f196 100644 --- a/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md +++ b/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md @@ -77,14 +77,15 @@ supported environment variables. ## OTLP Logs -This package currently only supports exporting traces and metrics. Once the -[OTLP log data model](https://github.com/open-telemetry/opentelemetry-proto#maturity-level) -is deemed stable, the OTLP log exporter will be folded into this package. - -In the meantime, support for exporting logs is provided by installing the +This package currently only supports exporting traces and metrics. Support for +exporting logs is provided by installing the [`OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs`](../OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs/README.md) package. +Once the OTLP log exporter is stable, it'll be folded into this package. Check +[this](https://github.com/open-telemetry/opentelemetry-dotnet/milestone/35) +milestone for tracking. + ## Special case when using insecure channel If your application is targeting .NET Core 3.1, and you are using an insecure diff --git a/src/OpenTelemetry/Metrics/MetricReaderTemporalityPreference.cs b/src/OpenTelemetry/Metrics/MetricReaderTemporalityPreference.cs index bbfc6d384c5..4443c4bb4a1 100644 --- a/src/OpenTelemetry/Metrics/MetricReaderTemporalityPreference.cs +++ b/src/OpenTelemetry/Metrics/MetricReaderTemporalityPreference.cs @@ -23,7 +23,7 @@ namespace OpenTelemetry.Metrics; public enum MetricReaderTemporalityPreference { /// - /// All aggregations are performed using cumulative temporatlity. + /// All aggregations are performed using cumulative temporality. /// Cumulative = 1,