Add aspnet metric example #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3033 +/- ##
==========================================
+ Coverage 84.70% 84.72% +0.02%
==========================================
Files 258 258
Lines 9095 9095
==========================================
+ Hits 7704 7706 +2
+ Misses 1391 1389 -2
|
cijothomas
reviewed
Mar 11, 2022
added 3 commits
March 11, 2022 14:28
…com/vishweshbankwar/opentelemetry-dotnet into vibankwa/add-aspnet-metrics-example
reyang
approved these changes
Mar 11, 2022
reyang
reviewed
Mar 11, 2022
| exporterOptions.Targets = ConsoleExporterOutputTargets.Debug; | ||
|
|
||
| // The ConsoleMetricExporter defaults to a manual collect cycle. | ||
| // This configuration causes metrics to be exported to stdout on a 10s interval. |
cijothomas
reviewed
Mar 12, 2022
|
|
||
| var meterBuilder = Sdk.CreateMeterProviderBuilder() | ||
| .AddAspNetInstrumentation() | ||
| .AddHttpClientInstrumentation(); |
There was a problem hiding this comment.
HttpClient for .NET FW don't produce metrics as of today, so its best to remove this line to avoid confusion. We can add it when httpclient starts having some metrics.
cijothomas
approved these changes
Mar 12, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.