Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TracerProviderSdk expects that ActivtyProcessor is Disposable #974

Closed
eddynaka opened this issue Aug 2, 2020 · 1 comment · Fixed by #975
Closed

TracerProviderSdk expects that ActivtyProcessor is Disposable #974

eddynaka opened this issue Aug 2, 2020 · 1 comment · Fixed by #975
Assignees
Labels
bug Something isn't working

Comments

@eddynaka
Copy link
Contributor

eddynaka commented Aug 2, 2020

Describe your environment. Describe any aspect of your environment relevant to the problem:

  • SDK version: (nuget versions of the all the relevant packages): master branch
  • .NET runtime version (.NET or .NET Core, TargetFramework in the .csproj file): any
  • Platform and OS version: any

If you're reporting a problem with a specific version of a library in this repo, please check whether the problem has been fixed on master.

if (this.ActivityProcessor is IDisposable disposableProcessor)
{
disposableProcessor.Dispose();
}

Steps to reproduce.
If we run Examples.Console -> console type in release, no data will be printed

What is the expected behavior?
If we run Examples.Console -> activity would be printed

What is the actual behavior?
If we run Examples.Console -> no data printed

Additional context.
Today, ActivityProcessor isn't implementing IDisposable

@eddynaka eddynaka added the bug Something isn't working label Aug 2, 2020
@eddynaka
Copy link
Contributor Author

eddynaka commented Aug 2, 2020

Assign me when possible. I will take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant