-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk] Expose the ctor on Batch<T> which accepts a single item #5642
[sdk] Expose the ctor on Batch<T> which accepts a single item #5642
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5642 +/- ##
==========================================
+ Coverage 83.38% 86.61% +3.22%
==========================================
Files 297 262 -35
Lines 12531 11804 -727
==========================================
- Hits 10449 10224 -225
+ Misses 2082 1580 -502
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@reyang is going to explore doing something with attributes to allow users to opt-into having |
I have a different idea how to solve this (and a category of similar problems), check #5643. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Re-opening this PR. There are some good alternative proposals in #5643 and #5758 however @alanwest and I feel we need to wait for the spec to prescribe what to do before moving forward: open-telemetry/opentelemetry-specification#4231 (comment). We have decided to expose this ctor in the meantime to unblock users. The spec says When the spec defines a concurrent simple processor it will be supported. But users should still be able to make custom implementations whatever they may be regardless. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
To help resolve: open-telemetry/opentelemetry-dotnet-contrib#1814
Changes
Batch<T>
which accepts a single item for the batch.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes